Update rewrite docs and cleanup

TASKS.md

@@ -46,6 +46,13 @@
 - Added tests for network-band rules, reactor-ready rules, inventory rules, removal effects, electricity leak access, and invalid rule targets.
 - Verified `dotnet test tests/ReactorMaintenance.Simulation.Tests/ReactorMaintenance.Simulation.Tests.csproj` passes after the rule slice: 21 passed.
 - Ran `jb cleanupcode --build=False ...` and `python D:\Code\crlf.py ...` for touched C# files after the rule slice.
+- Split serializable simulation records and enums from the monolithic `Models.cs` file into individual files under `Models`.
+- Moved level creation, grid mutation helpers, surface clamping, grid geometry, and inventory operations out of serializable model records.
+- Replaced separate T-junction and cross-junction props/tools with one topology-inferred `Junction` prop and one editor tool.
+- Moved junction ratio presets into balancing data.
+- Replaced hardcoded `EPairEffect` variants with parameterized surface interaction verbs and balance-owned magnitudes.
+- Introduced a small public `SimulationEngine` facade over an internal simulation system implementation.
+- Updated design documentation for generic junctions and parameterized surface interactions.
 
 ## Current Work
 
@@ -53,7 +60,7 @@
 
 ## Future Work
 
-1. Expand simulation fidelity where the first slice is intentionally simplified: complete pair table coverage and stronger forecast proof cases.
+1. Continue splitting the internal simulation system into smaller action, network, consumer, leak, surface interaction, robot safety, reactor, rule, and forecast systems.
 2. Add advanced editor workflows for explicit reactor binding selection, explicit door edge selection, electricity wall leak face selection, and rule event authoring.
 3. Verify and polish the Win2D app on Windows where the XAML compiler can run.
 4. Update README and any affected docs to reflect the new schema, .NET target, editor controls, and deterministic defaults.

docs/design.md

@@ -1,4 +1,4 @@
-# Reactor Maintenance Design
+# Reactor Maintenance Design
 
 ## Concept
 
@@ -114,8 +114,7 @@ Surface prop categories:
 
 - flow prop
 - consumer prop
-- T-junction prop
+- junction prop
-- cross-junction prop
 - door prop
 - all-seeing-eye terminal prop
 - remedy supply prop
@@ -155,24 +154,9 @@ The level is invalid if any binding is missing, out of bounds, or points to the
 
 A junction prop must be on a floor cell whose coordinate has exactly one underground carrier. That carrier is the regulated network.
 
-T-junction modes:
+The engine infers incoming and outgoing branch directions from valid network topology and enabled source paths. A valid junction has one incoming branch and either two or three outgoing branches. Ambiguous junction flow is invalid. Ratio numbers are balance-defined weights that divide carrier amount and pressure or voltage. A zero-weight branch receives no intentional outflow.
 
-- `0/4`
+The gameplay UI exposes a single junction tool and cycles through balance-defined ratio presets for the inferred outgoing branch count.
-- `1/3`
-- `2/2`
-- `3/1`
-- `4/0`
-
-Cross-junction modes:
-
-- `0/3/3`
-- `3/0/3`
-- `3/3/0`
-- `2/2/2`
-
-The engine infers incoming and outgoing branch directions from valid network topology and enabled source paths. Ambiguous junction flow is invalid. Ratio numbers are weights that divide carrier amount and pressure or voltage by balance-defined math. A zero-weight branch receives no intentional outflow.
-
-The gameplay UI exposes ratio modes.
 
 ### Doors
 
@@ -284,33 +268,28 @@ Balance thresholds project numeric values into safe, caution, and critical bands
 The pair table maps projected bands to deterministic effects:
 
 - `Hold`: no direct change.
-- `FuelFlow`: equalize leaked fuel.
+The pair table maps projected bands to parameterized verbs:
-- `CoolFlow`: equalize leaked coolant.
+
-- `ChargeFlow`: equalize leaked electricity.
+- `Hold`: no direct change.
-- `HeatFlow`: transfer heat.
+- `Flow(amount)`: equalize a surface quantity by a balance-defined transfer amount.
-- `HeatFlow2`: stronger heat transfer.
+- `Warm(amount)`: increase heat by a balance-defined amount.
-- `Warm1`: small heat increase from fuel exposure.
+- `Quench(amount)`: reduce heat by a balance-defined amount.
-- `Warm2`: larger heat increase from fuel exposure.
+- `Short(heat, discharge)`: add heat and discharge electricity by balance-defined amounts.
-- `Quench1`: small heat reduction from coolant exposure.
+- `Ignite(heat, fuel)`: add heat and consume fuel by balance-defined amounts.
-- `Quench2`: larger heat reduction from coolant exposure.
-- `Short1`: electricity and coolant interaction causing heat and discharge.
-- `Short2`: stronger short.
-- `Ignite1`: fuel interaction with electricity or high heat.
-- `Ignite2`: stronger ignition.
 
 | Row\Col | FuelSafe | FuelCaution | FuelCritical | CoolantSafe | CoolantCaution | CoolantCritical | ElectricitySafe | ElectricityCaution | ElectricityCritical | HeatSafe | HeatCaution | HeatCritical |
 | ------- | -------- | ----------- | ------------ | ----------- | -------------- | --------------- | --------------- | ------------------ | ------------------- | -------- | ----------- | ------------ |
-| FuelSafe | Hold | FuelFlow | FuelFlow | Hold | Hold | Hold | Hold | Warm1 | Warm2 | Hold | Warm1 | Warm2 |
+| FuelSafe | Hold | Flow | Flow | Hold | Hold | Hold | Hold | Warm | Ignite | Hold | Warm | Ignite |
-| FuelCaution |  | Hold | FuelFlow | Hold | Hold | Hold | Warm1 | Ignite1 | Ignite2 | Warm1 | Ignite1 | Ignite2 |
+| FuelCaution |  | Hold | Flow | Hold | Hold | Hold | Warm | Ignite | Ignite | Warm | Ignite | Ignite |
-| FuelCritical |  |  | Hold | Hold | Hold | Hold | Warm2 | Ignite2 | Ignite2 | Warm2 | Ignite2 | Ignite2 |
+| FuelCritical |  |  | Hold | Hold | Hold | Hold | Ignite | Ignite | Ignite | Ignite | Ignite | Ignite |
-| CoolantSafe |  |  |  | Hold | CoolFlow | CoolFlow | Hold | Short1 | Short2 | Hold | Quench1 | Quench1 |
+| CoolantSafe |  |  |  | Hold | Flow | Flow | Hold | Short | Short | Hold | Quench | Quench |
-| CoolantCaution |  |  |  |  | Hold | CoolFlow | Short1 | Short1 | Short2 | Hold | Quench1 | Quench2 |
+| CoolantCaution |  |  |  |  | Hold | Flow | Short | Short | Short | Hold | Quench | Quench |
-| CoolantCritical |  |  |  |  |  | Hold | Short2 | Short2 | Short2 | Hold | Quench2 | Quench2 |
+| CoolantCritical |  |  |  |  |  | Hold | Short | Short | Short | Hold | Quench | Quench |
-| ElectricitySafe |  |  |  |  |  |  | Hold | ChargeFlow | ChargeFlow | Hold | Hold | Hold |
+| ElectricitySafe |  |  |  |  |  |  | Hold | Flow | Flow | Hold | Hold | Hold |
-| ElectricityCaution |  |  |  |  |  |  |  | Hold | ChargeFlow | Hold | Hold | Hold |
+| ElectricityCaution |  |  |  |  |  |  |  | Hold | Flow | Hold | Hold | Hold |
 | ElectricityCritical |  |  |  |  |  |  |  |  | Hold | Hold | Hold | Hold |
-| HeatSafe |  |  |  |  |  |  |  |  |  | Hold | HeatFlow | HeatFlow2 |
+| HeatSafe |  |  |  |  |  |  |  |  |  | Hold | Flow | Flow |
-| HeatCaution |  |  |  |  |  |  |  |  |  |  | Hold | HeatFlow |
+| HeatCaution |  |  |  |  |  |  |  |  |  |  | Hold | Flow |
 | HeatCritical |  |  |  |  |  |  |  |  |  |  |  | Hold |
 
 Design rules:
@@ -422,7 +401,7 @@ The editor authors:
 - underground fuel, coolant, and electricity cells
 - flow props and consumer props
 - reactor controls and reactor consumer bindings
-- junction props and ratio modes
+- junction props and balance-defined ratio mode index
 - door props and door edges
 - all-seeing-eye terminals
 - remedy supplies

src/ReactorMaintenance.Simulation/Balancing.cs

@@ -1,4 +1,4 @@
-using ReactorMaintenance.Simulation.Difficulties;
+using ReactorMaintenance.Simulation.Difficulties;
 
 namespace ReactorMaintenance.Simulation;
 

src/ReactorMaintenance.Simulation/Difficulties/NormalBalancing.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation.Difficulties;
+namespace ReactorMaintenance.Simulation.Difficulties;
 
 public class NormalBalancing : Balancing
 {
@@ -30,6 +30,7 @@ public class NormalBalancing : Balancing
     public override float SourceIntensity => 8;
     public override float DistanceAmountFalloff => 0.5f;
     public override float DistanceIntensityFalloff => 0.4f;
+
     public override IReadOnlyList<JunctionRatioPreset> TwoOutflowJunctionRatios { get; } = [
         new("0/4", [0, 1]),
         new("1/3", [0.25f, 0.75f]),
@@ -37,12 +38,14 @@ public class NormalBalancing : Balancing
         new("3/1", [0.75f, 0.25f]),
         new("4/0", [1, 0])
     ];
+
     public override IReadOnlyList<JunctionRatioPreset> ThreeOutflowJunctionRatios { get; } = [
         new("0/3/3", [0, 0.5f, 0.5f]),
         new("3/0/3", [0.5f, 0, 0.5f]),
         new("3/3/0", [0.5f, 0.5f, 0]),
         new("2/2/2", [1f / 3f, 1f / 3f, 1f / 3f])
     ];
+
     public override float ConsumerRequiredAmount => 2.5f;
     public override float ConsumerRequiredIntensity => 2.5f;
     public override float LeakBaseAmount => 0.5f;

src/ReactorMaintenance.Simulation/GridPositionExtensions.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public static class GridPositionExtensions
 {

src/ReactorMaintenance.Simulation/JunctionRatioPreset.cs

@@ -1,3 +1,3 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record JunctionRatioPreset(string Label, float[] Weights);

src/ReactorMaintenance.Simulation/LevelEditor.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EEditorTool
 {

src/ReactorMaintenance.Simulation/LevelStateExtensions.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public static class LevelStateExtensions
 {

src/ReactorMaintenance.Simulation/LevelStateFactory.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public static class LevelStateFactory
 {

src/ReactorMaintenance.Simulation/Models/DoorState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record DoorState
 {

src/ReactorMaintenance.Simulation/Models/EBand.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EBand
 {

src/ReactorMaintenance.Simulation/Models/ECarrierType.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ECarrierType
 {

src/ReactorMaintenance.Simulation/Models/ECellTerrain.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ECellTerrain
 {

src/ReactorMaintenance.Simulation/Models/EConsumerServiceState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EConsumerServiceState
 {

src/ReactorMaintenance.Simulation/Models/EDoorState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EDoorState
 {

src/ReactorMaintenance.Simulation/Models/EForecastKind.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EForecastKind
 {

src/ReactorMaintenance.Simulation/Models/ELevelState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ELevelState
 {

src/ReactorMaintenance.Simulation/Models/ENetworkValueKind.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ENetworkValueKind
 {

src/ReactorMaintenance.Simulation/Models/EPropSwitchState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EPropSwitchState
 {

src/ReactorMaintenance.Simulation/Models/EPropType.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EPropType
 {

src/ReactorMaintenance.Simulation/Models/ERemedyType.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ERemedyType
 {

src/ReactorMaintenance.Simulation/Models/ERuleEffectKind.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ERuleEffectKind
 {

src/ReactorMaintenance.Simulation/Models/ERuleEventPhase.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ERuleEventPhase
 {

src/ReactorMaintenance.Simulation/Models/ERulePredicateKind.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ERulePredicateKind
 {

src/ReactorMaintenance.Simulation/Models/ESurfaceInteractionVerb.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ESurfaceInteractionVerb
 {

src/ReactorMaintenance.Simulation/Models/ESurfaceQuantity.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum ESurfaceQuantity
 {

src/ReactorMaintenance.Simulation/Models/EUndergroundState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public enum EUndergroundState
 {

src/ReactorMaintenance.Simulation/Models/Forecast.cs

@@ -1,3 +1,3 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record Forecast(EForecastKind Kind, GridPosition? Position, int Turns, string Message);

src/ReactorMaintenance.Simulation/Models/GlobalState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record GlobalState
 {

src/ReactorMaintenance.Simulation/Models/GridPosition.cs

@@ -1,3 +1,3 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record GridPosition(int X, int Y);

src/ReactorMaintenance.Simulation/Models/LeakState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record LeakState
 {

src/ReactorMaintenance.Simulation/Models/LevelState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record LevelState
 {

src/ReactorMaintenance.Simulation/Models/PropState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record PropState
 {

src/ReactorMaintenance.Simulation/Models/ReactorBinding.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record ReactorBinding
 {

src/ReactorMaintenance.Simulation/Models/RobotState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record RobotState
 {

src/ReactorMaintenance.Simulation/Models/RuleEffect.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record RuleEffect
 {

src/ReactorMaintenance.Simulation/Models/RuleEventState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record RuleEventState
 {

src/ReactorMaintenance.Simulation/Models/RulePredicate.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record RulePredicate
 {

src/ReactorMaintenance.Simulation/Models/SurfaceState.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record SurfaceState
 {

src/ReactorMaintenance.Simulation/Models/UndergroundCell.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record UndergroundCell
 {

src/ReactorMaintenance.Simulation/Models/ValidationIssue.cs

@@ -1,3 +1,3 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record ValidationIssue(string Message, GridPosition? Position = null);

src/ReactorMaintenance.Simulation/Models/ValidationReport.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record ValidationReport
 {

src/ReactorMaintenance.Simulation/RobotStateExtensions.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public static class RobotStateExtensions
 {

src/ReactorMaintenance.Simulation/SimulationEngine.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed class SimulationEngine
 {

src/ReactorMaintenance.Simulation/SurfaceInteractionEffect.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public sealed record SurfaceInteractionEffect
 {

src/ReactorMaintenance.Simulation/SurfaceStateExtensions.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 public static class SurfaceStateExtensions
 {

src/ReactorMaintenance.Simulation/Systems/SimulationCoreSystem.cs

@@ -1,4 +1,4 @@
-namespace ReactorMaintenance.Simulation;
+namespace ReactorMaintenance.Simulation;
 
 internal sealed class SimulationCoreSystem
 {
@@ -704,4 +704,3 @@ internal sealed class SimulationCoreSystem
 
     private readonly LevelValidator m_Validator = new();
 }
-

src/ReactorMaintenance.Win2D/MainWindow.xaml.cs

@@ -1,4 +1,4 @@
-using Microsoft.Graphics.Canvas;
+using Microsoft.Graphics.Canvas;
 using Microsoft.Graphics.Canvas.Text;
 using Microsoft.Graphics.Canvas.UI.Xaml;
 using Microsoft.UI;