fix: unify custom roll visibility

RpgRoller/Components/Pages/HomeControls/CampaignLogPanel.razor.cs

@@ -198,8 +198,8 @@ public partial class CampaignLogPanel
 
     private string CustomRollStatusText =>
         SelectedCharacterId.HasValue && !string.IsNullOrWhiteSpace(SelectedCharacterName)
-            ? $"For {SelectedCharacterName} • {RollVisibilityLabel}"
+            ? $"For {SelectedCharacterName} • Uses {RollVisibilityLabel.ToLowerInvariant()} visibility"
-            : "Select a character to enable";
+            : $"Select a character to enable • {RollVisibilityLabel} visibility selected";
 
     private string CustomRollHelpText => SelectedCampaignRulesetId.ToLowerInvariant() switch
     {

RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor

@@ -59,7 +59,10 @@
                     </div>
                     <div class="chip-toolbar">
                         <label class="visibility-control" for="roll-visibility">Visibility</label>
-                        <select id="roll-visibility" value="@(RollVisibility == "private" ? "private" : "public")" @onchange="OnRollVisibilityChangedAsync">
+                        <select id="roll-visibility"
+                                @bind:get="NormalizedRollVisibility"
+                                @bind:set="OnRollVisibilityChangedAsync"
+                                @bind:event="oninput">
                             <option value="public">Public</option>
                             <option value="private">Private</option>
                         </select>

RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor.cs

@@ -70,10 +70,9 @@ public partial class CharacterPanel
         await SkillUpdated.InvokeAsync(skillId);
     }
 
-    private async Task OnRollVisibilityChangedAsync(ChangeEventArgs args)
+    private async Task OnRollVisibilityChangedAsync(string? selectedVisibility)
     {
-        var selectedVisibility = args.Value?.ToString() ?? "public";
+        await RollVisibilityChanged.InvokeAsync(selectedVisibility ?? "public");
-        await RollVisibilityChanged.InvokeAsync(selectedVisibility);
     }
 
     private async Task RollSkillAsync(CharacterSheetSkill skill)
@@ -372,6 +371,9 @@ public partial class CharacterPanel
 
     [Parameter] public EventCallback<string> RollVisibilityChanged { get; set; }
 
+    private string NormalizedRollVisibility =>
+        string.Equals(RollVisibility, "private", StringComparison.OrdinalIgnoreCase) ? "private" : "public";
+
     [Parameter] public Func<Guid, string> OwnerLabel { get; set; } = _ => string.Empty;
 
     [Parameter] public Func<CharacterSheetSkill, string> SkillDefinitionLabel { get; set; } = _ => string.Empty;

RpgRoller/Components/Pages/Workspace.razor.cs

@@ -171,7 +171,7 @@ public partial class Workspace : IAsyncDisposable
     private WorkspaceSessionCoordinator Session => m_Session ??= new(State, Feedback, JS, ApiClient, WorkspaceQuery,
         () => IsAdminRoute, RedirectToPlayAsync,
         Scope.ReloadCampaignsAsync, Scope.ReloadCharacterCampaignOptionsAsync, Scope.RefreshCampaignScopeAsync,
-        Live.SyncStateEventsAsync, Live.StopStateEventsAsync, EnsureAdminUsersLoadedAsync,
+        RequestRefreshAsync, Live.SyncStateEventsAsync, Live.StopStateEventsAsync, EnsureAdminUsersLoadedAsync,
         Play.ResetCampaignLogDetailState, message => LoggedOut.InvokeAsync(message));
 
     private IReadOnlyList<AppHeaderMenuItem> HeaderMenuItems

RpgRoller/Components/Pages/WorkspaceSessionCoordinator.cs

@@ -14,6 +14,7 @@ public sealed class WorkspaceSessionCoordinator(
     Func<Guid?, Task> reloadCampaignsAsync,
     Func<Task> reloadCharacterCampaignOptionsAsync,
     Func<Task> refreshCampaignScopeAsync,
+    Func<Task> requestRefreshAsync,
     Func<Task> syncStateEventsAsync,
     Func<Task> stopStateEventsAsync,
     Func<Task> ensureAdminUsersLoadedAsync,
@@ -97,6 +98,7 @@ public sealed class WorkspaceSessionCoordinator(
     {
         state.RollVisibility = NormalizeRollVisibility(visibility);
         await js.InvokeVoidAsync("rpgRollerApi.setSessionValue", RollVisibilitySessionKey, state.RollVisibility);
+        await requestRefreshAsync();
     }
 
     public void ClearAuthenticatedState()

tests/e2e/smoke.js

@@ -503,6 +503,8 @@ const tests = [
         }),
         "Expected custom roll composer to be interactive."
       );
+      assert.match(await elementText(driver, ".custom-roll-composer-head .muted"), /uses public visibility/i);
+
       await fillInput(driver, "#custom-roll-expression", "bad");
       await clickText(driver, ".custom-roll-composer button", "Roll");
 
@@ -525,7 +527,9 @@ const tests = [
         () => driver.executeScript(() => {
           const className = document.querySelector("#custom-roll-expression")?.className || "";
           const firstLogEntry = document.querySelector(".log-panel .log-entry");
-          return !/error/.test(className) && Boolean(firstLogEntry?.textContent.includes("Custom roll"));
+          return !/error/.test(className) &&
+            Boolean(firstLogEntry?.textContent.includes("Custom roll")) &&
+            Boolean(firstLogEntry?.textContent.includes("Public"));
         }),
         "Expected successful custom roll entry."
       );