From 7248b603956cd408e4a1b53567d5ad8fb0ddd197 Mon Sep 17 00:00:00 2001 From: Frank Tovar Date: Fri, 3 Apr 2026 23:04:35 +0200 Subject: [PATCH] Show full campaign log roll summaries --- RpgRoller.Tests/Services/ServiceSkillRollTests.cs | 2 +- RpgRoller/Services/GameService.cs | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/RpgRoller.Tests/Services/ServiceSkillRollTests.cs b/RpgRoller.Tests/Services/ServiceSkillRollTests.cs index c99c767..3795240 100644 --- a/RpgRoller.Tests/Services/ServiceSkillRollTests.cs +++ b/RpgRoller.Tests/Services/ServiceSkillRollTests.cs @@ -168,7 +168,7 @@ public sealed class ServiceSkillRollTests var d6Entry = Assert.Single(ServiceTestSupport.GetValue(service.GetCampaignLogPage(gmSession, d6Campaign.Id, limit: 5)).Entries); var d6Badges = Assert.IsType(d6Entry.EventBadges); Assert.Equal("w6", Assert.Single(d6Badges)); - Assert.Equal("6, 4, 6, ...", d6Entry.SummaryText); + Assert.Equal("6, 4, 6, 6, 2", d6Entry.SummaryText); var dndCampaign = ServiceTestSupport.GetValue(service.CreateCampaign(gmSession, "Dnd Special", "dnd5e")); var dndCharacter = ServiceTestSupport.GetValue(service.CreateCharacter(ownerSession, "Natural Hero", dndCampaign.Id)); diff --git a/RpgRoller/Services/GameService.cs b/RpgRoller/Services/GameService.cs index 1fe142f..826cadc 100644 --- a/RpgRoller/Services/GameService.cs +++ b/RpgRoller/Services/GameService.cs @@ -1376,11 +1376,7 @@ public sealed class GameService : IGameService if (dice.Any(die => IsRolemasterDieKind(die.Kind))) return BuildRolemasterCompactLogSummary(dice); - var preview = string.Join(", ", dice.Take(3).Select(die => die.Roll.ToString())); - if (dice.Count > 3) - preview = $"{preview}, ..."; - - return preview; + return string.Join(", ", dice.Select(die => die.Roll.ToString())); } private static string BuildRolemasterCompactLogSummary(IReadOnlyList dice) @@ -1407,14 +1403,11 @@ public sealed class GameService : IGameService if (dice.Any(die => string.Equals(die.Kind, RollDieKinds.RolemasterStandard, StringComparison.Ordinal))) { - var preview = string.Join(" + ", dice.Take(3).Select(die => die.Roll.ToString())); - if (dice.Count > 3) - preview = $"{preview} + ..."; - + var preview = string.Join(" + ", dice.Select(die => die.Roll.ToString())); return $"{preview} | rolemaster"; } - return string.Join(", ", dice.Take(3).Select(die => die.Roll.ToString())); + return string.Join(", ", dice.Select(die => die.Roll.ToString())); } private static bool IsRolemasterDieKind(string? kind)