From 6b180510739cff4b5ca1ebb8b924fd7d567d2e21 Mon Sep 17 00:00:00 2001
From: Frank <mail@franktovar.de>
Date: Tue, 5 May 2026 00:48:15 +0200
Subject: [PATCH] fix: restore visibility select behavior

---
 .../Components/Pages/HomeControls/CharacterPanel.razor    | 5 ++---
 .../Components/Pages/HomeControls/CharacterPanel.razor.cs | 8 +++-----
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor b/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor
index f688c36..c8343e9 100644
--- a/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor
+++ b/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor
@@ -60,9 +60,8 @@
                     <div class="chip-toolbar">
                         <label class="visibility-control" for="roll-visibility">Visibility</label>
                         <select id="roll-visibility"
-                                @bind:get="NormalizedRollVisibility"
-                                @bind:set="OnRollVisibilityChangedAsync"
-                                @bind:event="oninput">
+                                value="@(RollVisibility == "private" ? "private" : "public")"
+                                @onchange="OnRollVisibilityChangedAsync">
                             <option value="public">Public</option>
                             <option value="private">Private</option>
                         </select>
diff --git a/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor.cs b/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor.cs
index e6f782c..12b07c6 100644
--- a/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor.cs
+++ b/RpgRoller/Components/Pages/HomeControls/CharacterPanel.razor.cs
@@ -70,9 +70,10 @@ public partial class CharacterPanel
         await SkillUpdated.InvokeAsync(skillId);
     }
 
-    private async Task OnRollVisibilityChangedAsync(string? selectedVisibility)
+    private async Task OnRollVisibilityChangedAsync(ChangeEventArgs args)
     {
-        await RollVisibilityChanged.InvokeAsync(selectedVisibility ?? "public");
+        var selectedVisibility = args.Value?.ToString() ?? "public";
+        await RollVisibilityChanged.InvokeAsync(selectedVisibility);
     }
 
     private async Task RollSkillAsync(CharacterSheetSkill skill)
@@ -371,9 +372,6 @@ public partial class CharacterPanel
 
     [Parameter] public EventCallback<string> RollVisibilityChanged { get; set; }
 
-    private string NormalizedRollVisibility =>
-        string.Equals(RollVisibility, "private", StringComparison.OrdinalIgnoreCase) ? "private" : "public";
-
     [Parameter] public Func<Guid, string> OwnerLabel { get; set; } = _ => string.Empty;
 
     [Parameter] public Func<CharacterSheetSkill, string> SkillDefinitionLabel { get; set; } = _ => string.Empty;