Code Cleanup

RpgRoller.Tests/Api/AuthApiTests.cs

@@ -48,4 +48,4 @@ public sealed class AuthApiTests : ApiTestBase
         var usernames = await GetAsync<IReadOnlyList<string>>(client, "/api/users/usernames");
         Assert.Equal(["amy", "bob", "zoe"], usernames);
     }
-}
+}

RpgRoller.Tests/Api/CampaignApiTests.cs

@@ -138,7 +138,7 @@ public sealed class CampaignApiTests : ApiTestBase
         var groupedSkill = await PostAsync<CreateSkillRequest, SkillSummary>(ownerClient, $"/api/characters/{character.Id}/skills", new("Strike", "2D+1", 1, true, renamedGroup.Id));
         Assert.Equal(renamedGroup.Id, groupedSkill.SkillGroupId);
 
-        var ungroupedSkill = await PutAsync<UpdateSkillRequest, SkillSummary>(ownerClient, $"/api/skills/{groupedSkill.Id}", new("Strike", "2D+1", 1, true, null));
+        var ungroupedSkill = await PutAsync<UpdateSkillRequest, SkillSummary>(ownerClient, $"/api/skills/{groupedSkill.Id}", new("Strike", "2D+1", 1, true));
         Assert.Null(ungroupedSkill.SkillGroupId);
 
         var groupedAgainSkill = await PutAsync<UpdateSkillRequest, SkillSummary>(ownerClient, $"/api/skills/{groupedSkill.Id}", new("Strike", "2D+1", 1, true, renamedGroup.Id));
@@ -187,7 +187,7 @@ public sealed class CampaignApiTests : ApiTestBase
         Assert.Contains(adminEntry.Roles, role => string.Equals(role, "admin", StringComparison.OrdinalIgnoreCase));
         Assert.Empty(playerEntry.Roles);
 
-        var promotedPlayer = await PutAsync<UpdateUserRolesRequest, AdminUserSummary>(adminClient, $"/api/admin/users/{player.Id}/roles", new([ "admin" ]));
+        var promotedPlayer = await PutAsync<UpdateUserRolesRequest, AdminUserSummary>(adminClient, $"/api/admin/users/{player.Id}/roles", new(["admin"]));
         Assert.Contains(promotedPlayer.Roles, role => string.Equals(role, "admin", StringComparison.OrdinalIgnoreCase));
 
         var campaign = await PostAsync<CreateCampaignRequest, CampaignSummary>(gmClient, "/api/campaigns", new("Disposable Campaign", "d6"));
@@ -404,4 +404,4 @@ public sealed class CampaignApiTests : ApiTestBase
         Assert.Equal(latestRoll.Breakdown, detail.Breakdown);
         Assert.NotEmpty(detail.Dice);
     }
-}
+}

RpgRoller.Tests/Api/FrontendHostTests.cs

@@ -18,4 +18,4 @@ public sealed class FrontendHostTests : ApiTestBase
         Assert.Contains("_framework/blazor.web.js", html);
         Assert.Contains("Connecting...", html);
     }
-}
+}

RpgRoller.Tests/Api/ResponseCompressionApiTests.cs

@@ -24,4 +24,4 @@ public sealed class ResponseCompressionApiTests : ApiTestBase
         response.EnsureSuccessStatusCode();
         Assert.Contains("gzip", response.Content.Headers.ContentEncoding);
     }
-}
+}

RpgRoller.Tests/Api/RolemasterApiTests.cs

@@ -61,36 +61,28 @@ public sealed class RolemasterApiTests : ApiTestBase
         var logEntry = Assert.Single(logPage.Entries);
         Assert.Equal("(05) -97 -100 -12 | open-ended low", logEntry.SummaryText);
         var eventBadges = Assert.IsType<string[]>(logEntry.EventBadges);
-        Assert.Collection(
-            eventBadges,
-            badge => Assert.Equal("rf", badge),
-            badge => Assert.Equal("r100", badge));
+        Assert.Collection(eventBadges, badge => Assert.Equal("rf", badge), badge => Assert.Equal("r100", badge));
         Assert.Equal(roll.Breakdown, detail.Breakdown);
-        Assert.Collection(
-            detail.Dice,
-            die =>
-            {
-                Assert.Equal(RollDieKinds.RolemasterOpenEndedInitial, die.Kind);
-                Assert.Equal(1, die.Sequence);
-                Assert.Null(die.SignedContribution);
-            },
-            die =>
-            {
-                Assert.Equal(RollDieKinds.RolemasterOpenEndedLowSubtract, die.Kind);
-                Assert.Equal(2, die.Sequence);
-                Assert.Equal(-97, die.SignedContribution);
-            },
-            die =>
-            {
-                Assert.Equal(RollDieKinds.RolemasterOpenEndedLowSubtract, die.Kind);
-                Assert.Equal(3, die.Sequence);
-                Assert.Equal(-100, die.SignedContribution);
-            },
-            die =>
-            {
-                Assert.Equal(RollDieKinds.RolemasterOpenEndedLowSubtract, die.Kind);
-                Assert.Equal(4, die.Sequence);
-                Assert.Equal(-12, die.SignedContribution);
-            });
+        Assert.Collection(detail.Dice, die =>
+        {
+            Assert.Equal(RollDieKinds.RolemasterOpenEndedInitial, die.Kind);
+            Assert.Equal(1, die.Sequence);
+            Assert.Null(die.SignedContribution);
+        }, die =>
+        {
+            Assert.Equal(RollDieKinds.RolemasterOpenEndedLowSubtract, die.Kind);
+            Assert.Equal(2, die.Sequence);
+            Assert.Equal(-97, die.SignedContribution);
+        }, die =>
+        {
+            Assert.Equal(RollDieKinds.RolemasterOpenEndedLowSubtract, die.Kind);
+            Assert.Equal(3, die.Sequence);
+            Assert.Equal(-100, die.SignedContribution);
+        }, die =>
+        {
+            Assert.Equal(RollDieKinds.RolemasterOpenEndedLowSubtract, die.Kind);
+            Assert.Equal(4, die.Sequence);
+            Assert.Equal(-12, die.SignedContribution);
+        });
     }
-}
+}

RpgRoller.Tests/Api/RollVisibilityApiTests.cs

@@ -97,4 +97,4 @@ public sealed class RollVisibilityApiTests : ApiTestBase
         var unauthorizedWithInvalidSession = await anonymousClient.SendAsync(invalidSessionRequest);
         Assert.Equal(HttpStatusCode.Unauthorized, unauthorizedWithInvalidSession.StatusCode);
     }
-}
+}

RpgRoller.Tests/Api/SystemApiTests.cs

@@ -26,4 +26,4 @@ public sealed class SystemApiTests : ApiTestBase
         Assert.Equal(HttpStatusCode.OK, sseResponse.StatusCode);
         Assert.Equal("text/event-stream", sseResponse.Content.Headers.ContentType?.MediaType);
     }
-}
+}