Enforce phase for suggestions with joker allowance

This commit is contained in:
2026-02-05 17:15:30 +01:00
parent ffbf4aa05a
commit e3d4e2e687
2 changed files with 32 additions and 2 deletions

View File

@@ -3,6 +3,7 @@ using GameList.Data;
using GameList.Domain;
using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore;
using GameList.Infrastructure;
namespace GameList.Endpoints;
@@ -71,7 +72,6 @@ public static class SuggestEndpoints
var usingJoker = phase == Phase.Vote && player.HasJoker;
if (phase != Phase.Suggest && !usingJoker)
return EndpointHelpers.PhaseMismatch(Phase.Suggest, phase);
if (string.IsNullOrWhiteSpace(player.DisplayName))
{
return Results.BadRequest(new { error = "Set a display name before submitting suggestions." });
@@ -107,7 +107,8 @@ public static class SuggestEndpoints
await db.SaveChangesAsync();
return Results.Created($"/api/suggestions/{suggestion.Id}", new { suggestion.Id });
});
})
.AddEndpointFilter(new PhaseOrJokerFilter());
group.MapDelete("/{id:int}", async (int id, HttpContext ctx, AppDbContext db) =>
{

View File

@@ -0,0 +1,29 @@
using GameList.Data;
using GameList.Domain;
using GameList.Endpoints;
namespace GameList.Infrastructure;
/// <summary>
/// Allows Suggest phase, or Vote phase when the player has a joker available.
/// Used for creating suggestions during Vote with joker.
/// </summary>
public class PhaseOrJokerFilter : IEndpointFilter
{
public async ValueTask<object?> InvokeAsync(EndpointFilterInvocationContext context, EndpointFilterDelegate next)
{
var httpContext = context.HttpContext;
var db = httpContext.RequestServices.GetRequiredService<AppDbContext>();
var player = await EndpointHelpers.GetAuthenticatedPlayer(httpContext, db);
if (player is null) return Results.Unauthorized();
var phase = await EndpointHelpers.GetPhase(db, player.Id);
var allow = phase == Phase.Suggest || (phase == Phase.Vote && player.HasJoker);
if (!allow)
{
return EndpointHelpers.PhaseMismatch(Phase.Suggest, phase);
}
return await next(context);
}
}