From b67753ff9ed5ff8a9878329f533929a91e4aa8fd Mon Sep 17 00:00:00 2001 From: Frank Tovar Date: Sat, 7 Feb 2026 13:32:49 +0100 Subject: [PATCH] Code cleanup --- Endpoints/StateWorkflowService.cs | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/Endpoints/StateWorkflowService.cs b/Endpoints/StateWorkflowService.cs index 0055f72..dc5ccea 100644 --- a/Endpoints/StateWorkflowService.cs +++ b/Endpoints/StateWorkflowService.cs @@ -76,20 +76,12 @@ internal sealed class StateWorkflowService(AppDbContext db) return EndpointHelpers.BadRequestError("Only admins can move backward."); var appState = await db.AppState.FirstAsync(); - var shouldSave = EndpointHelpers.ReconcilePlayerPhase(player, appState.ResultsOpen); + _ = EndpointHelpers.ReconcilePlayerPhase(player, appState.ResultsOpen); - try - { - player.CurrentPhase = PrevPhase(player.CurrentPhase); - player.VotesFinal = false; - shouldSave = true; - return Results.Ok(new PhaseTransitionResponse(player.CurrentPhase, appState.ResultsOpen)); - } - finally - { - if (shouldSave) - await db.SaveChangesAsync(); - } + player.CurrentPhase = PrevPhase(player.CurrentPhase); + player.VotesFinal = false; + await db.SaveChangesAsync(); + return Results.Ok(new PhaseTransitionResponse(player.CurrentPhase, appState.ResultsOpen)); } private static Phase NextPhase(Phase current) => current switch