xTr1m/GameList
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

removed smoke test script

Browse Source
This commit is contained in:
Frank Tovar
2026-02-07 00:09:47 +01:00
parent 93f3dcf382
commit 7ecf2b4a59
2 changed files with 1 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
REVIEW.md
View File

@@ -13,7 +13,6 @@ Top 5 maintainability risks (priority order):
2. Operational contract drift between docs/scripts/code (High)
- `API.md:3` claims admin auth via `X-Admin-Key`/`key`; admin runtime actually checks authenticated admin user (`Infrastructure/AdminOnlyFilter.cs:12`).
- `scripts/smoke.ps1:46`/`scripts/smoke.ps1:51` call admin endpoints using `X-Admin-Key` and contain a `TODO` (`scripts/smoke.ps1:48`), so smoke automation is not trustworthy.
- Impact: incident response and deployment validation are unreliable.
3. High-change, high-complexity frontend hotspots (High)
@@ -55,7 +54,7 @@ Major modules/components and responsibilities:
- `Domain/*.cs`: entity data structures (`Player`, `Suggestion`, `Vote`, `AppState`, `Phase`).
- `wwwroot/app.js` + `wwwroot/js/*.js`: frontend orchestration, shared state, API calls, rendering, i18n, effects.
- `GameList.Tests/*.cs`: integration-heavy endpoint tests plus helper/unit tests.
- `scripts/*.ps1`: deployment and smoke automation.
- `scripts/*.ps1`: deployment automation.
Boundary quality:
- Backend boundaries are leaky: endpoint layer owns domain rules, persistence orchestration, and security checks directly.