Expand test coverage to match specs

GameList.Tests/VoteTests.cs

@@ -1,5 +1,6 @@
 using System.Net;
 using System.Net.Http.Json;
+using System.Text.Json;
 using GameList.Tests.Support;
 using Microsoft.EntityFrameworkCore;
 
@@ -42,6 +43,19 @@ public class VoteTests
         Assert.Equal(HttpStatusCode.BadRequest, resp.StatusCode);
     }
 
+    [Fact]
+    public async Task Negative_score_rejected()
+    {
+        using var factory = new TestWebApplicationFactory();
+        var client = factory.CreateClientWithCookies();
+        await client.RegisterAsync("negative");
+        var id = await client.CreateSuggestionAsync("RangeGame2");
+        await client.PostAsJsonAsync("/api/me/phase/next", new { });
+
+        var resp = await client.PostAsJsonAsync("/api/votes", new { SuggestionId = id, Score = -1 });
+        Assert.Equal(HttpStatusCode.BadRequest, resp.StatusCode);
+    }
+
     [Fact]
     public async Task Invalid_suggestion_id_rejected()
     {
@@ -85,6 +99,25 @@ public class VoteTests
         Assert.Equal(HttpStatusCode.BadRequest, resp.StatusCode);
     }
 
+    [Fact]
+    public async Task Finalize_toggle_allows_unfinalize()
+    {
+        using var factory = new TestWebApplicationFactory();
+        var client = factory.CreateClientWithCookies();
+        await client.RegisterAsync("toggle");
+        var id = await client.CreateSuggestionAsync("Toggle");
+        await client.PostAsJsonAsync("/api/me/phase/next", new { });
+        await client.PostAsJsonAsync("/api/votes", new { SuggestionId = id, Score = 5 });
+
+        var finalize = await client.PostAsJsonAsync("/api/votes/finalize", new { Final = true });
+        finalize.EnsureSuccessStatusCode();
+        var unfinalize = await client.PostAsJsonAsync("/api/votes/finalize", new { Final = false });
+        unfinalize.EnsureSuccessStatusCode();
+
+        var me = await client.GetFromJsonAsync<JsonElement>("/api/me");
+        Assert.False(me.GetProperty("votesFinal").GetBoolean());
+    }
+
     [Fact]
     public async Task Linked_votes_apply_to_all_linked_suggestions()
     {
@@ -114,5 +147,48 @@ public class VoteTests
         Assert.All(mine, v => Assert.Equal(9, v.Score));
     }
 
+    [Fact]
+    public async Task Linked_votes_apply_across_chain()
+    {
+        using var factory = new TestWebApplicationFactory();
+        var admin = factory.CreateClientWithCookies();
+        await admin.RegisterAsync("admin", admin: true);
+        await admin.PostAsJsonAsync("/api/me/phase/next", new { });
+
+        var player = factory.CreateClientWithCookies();
+        await player.RegisterAsync("chain");
+
+        var a = await player.CreateSuggestionAsync("A");
+        var b = await player.CreateSuggestionAsync("B");
+        var c = await player.CreateSuggestionAsync("C");
+
+        await player.PostAsJsonAsync("/api/me/phase/next", new { });
+
+        await admin.PostAsJsonAsync("/api/admin/link-suggestions", new { SourceSuggestionId = a, TargetSuggestionId = b });
+        await admin.PostAsJsonAsync("/api/admin/link-suggestions", new { SourceSuggestionId = b, TargetSuggestionId = c });
+
+        var vote = await player.PostAsJsonAsync("/api/votes", new { SuggestionId = c, Score = 6 });
+        vote.EnsureSuccessStatusCode();
+
+        var mine = await player.GetFromJsonAsync<List<VoteRecord>>("/api/votes/mine");
+        Assert.NotNull(mine);
+        Assert.Equal(3, mine!.Count);
+        Assert.All(mine, v => Assert.Equal(6, v.Score));
+    }
+
+    [Fact]
+    public async Task Votes_mine_requires_vote_phase_and_auth()
+    {
+        using var factory = new TestWebApplicationFactory();
+        var anon = factory.CreateClient();
+        var unauth = await anon.GetAsync("/api/votes/mine");
+        Assert.Equal(HttpStatusCode.Unauthorized, unauth.StatusCode);
+
+        var client = factory.CreateClientWithCookies();
+        await client.RegisterAsync("phaseguard");
+        var resp = await client.GetAsync("/api/votes/mine");
+        Assert.Equal(HttpStatusCode.BadRequest, resp.StatusCode);
+    }
+
     private record VoteRecord(int SuggestionId, int Score);
 }