Add analyzer and frontend lint guardrails
This commit is contained in:
17
REVIEW.md
17
REVIEW.md
@@ -6,20 +6,12 @@ This document tracks only active work. Completed work is intentionally omitted a
|
||||
|
||||
Active maintainability risks (priority order):
|
||||
|
||||
1. Static analysis and frontend lint guardrails are still missing (Medium)
|
||||
- CI currently gates restore/build/test only (`.github/workflows/ci.yml:23`-`.github/workflows/ci.yml:29`).
|
||||
- Impact: style drift and low-signal warnings can enter the codebase undetected.
|
||||
1. Externalized frontend content assets are still pending (Low)
|
||||
- Translation and FAQ payloads are still embedded in executable JS (`wwwroot/js/i18n.js:1`-`wwwroot/js/i18n.js:799`).
|
||||
- Impact: content changes require touching behavior modules and increase review noise.
|
||||
|
||||
## B) Active task list
|
||||
|
||||
[P2] Add static analysis and JS lint/format guardrails
|
||||
- Problem: Severity `Medium`, Category `Tooling`. CI does not enforce analyzers or JS lint/format checks.
|
||||
- Evidence: `.github/workflows/ci.yml:23`-`.github/workflows/ci.yml:29`.
|
||||
- Recommendation: add .NET analyzer configuration and ESLint/Prettier checks, then enforce in CI.
|
||||
- Acceptance criteria (testable): CI fails on analyzer/lint violations; local scripts are documented in root docs.
|
||||
- Effort / Risk: `M / Low`.
|
||||
- Dependencies (if any): none.
|
||||
|
||||
[P2] Externalize i18n and FAQ content from executable JS
|
||||
- Problem: Severity `Low`, Category `Complexity/Documentation`. Translation and FAQ payloads are embedded in code.
|
||||
- Evidence: `wwwroot/js/i18n.js:1`-`wwwroot/js/i18n.js:799`.
|
||||
@@ -30,8 +22,7 @@ Active maintainability risks (priority order):
|
||||
|
||||
## C) Suggested execution order
|
||||
|
||||
1. Add analyzers + JS lint gates in CI.
|
||||
2. Externalize i18n/FAQ assets.
|
||||
1. Externalize i18n/FAQ assets.
|
||||
|
||||
## D) Guardrails
|
||||
|
||||
|
||||
Reference in New Issue
Block a user